-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): rename prefix to account #6814
Merged
wangsijie
merged 1 commit into
master
from
wangsijie-log-10350-rename-prefix-to-account
Nov 18, 2024
Merged
refactor(core): rename prefix to account #6814
wangsijie
merged 1 commit into
master
from
wangsijie-log-10350-rename-prefix-to-account
Nov 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
Name | Diff |
---|---|
packages/core/src/routes/account-center/index.openapi.json | 📈 +105 Bytes |
packages/core/src/routes/account/constants.ts | 📈 +44 Bytes |
packages/core/src/routes/account/email-and-phone.ts | 📈 +6.42 KB |
packages/core/src/routes/account/identities.ts | 📈 +3.6 KB |
packages/core/src/routes/account/index.openapi.json | 📈 +9.35 KB |
packages/core/src/routes/account/index.ts | 📈 +5.82 KB |
packages/core/src/routes/account/middlewares/koa-account-center.ts | 📈 +1.02 KB |
packages/core/src/routes/account/utils/get-scoped-profile.ts | 📈 +3.17 KB |
packages/core/src/routes/init.ts | 📈 +97 Bytes |
packages/core/src/routes/profile/email-and-phone.ts | 📈 +6.33 KB |
packages/core/src/routes/profile/identities.ts | 📈 +3.53 KB |
packages/core/src/routes/profile/index.openapi.json | 📈 +9.35 KB |
packages/core/src/routes/profile/index.ts | 📈 +5.72 KB |
packages/core/src/routes/profile/middlewares/koa-account-center.ts | 📈 +1.02 KB |
packages/core/src/routes/profile/utils/get-scoped-profile.ts | 📈 +3.17 KB |
packages/core/src/routes/swagger/utils/operation-id.ts | 0 Bytes |
packages/core/src/routes/types.ts | 0 Bytes |
packages/core/src/routes/verification/index.ts | 📈 +106 Bytes |
packages/core/src/routes/well-known/well-known.openapi.ts | 0 Bytes |
packages/integration-tests/src/api/profile.ts | 0 Bytes |
packages/integration-tests/src/tests/api/account/account-center-reject.test.ts | 📈 +3.63 KB |
packages/integration-tests/src/tests/api/account/email-and-phone.test.ts | |
packages/integration-tests/src/tests/api/account/index.test.ts | |
packages/integration-tests/src/tests/api/account/social.test.ts | 📈 +8.85 KB |
packages/integration-tests/src/tests/api/profile/account-center-reject.test.ts | 📈 +3.64 KB |
packages/integration-tests/src/tests/api/profile/email-and-phone.test.ts | 📈 +16.07 KB |
packages/integration-tests/src/tests/api/profile/index.test.ts | 📈 +11.09 KB |
packages/integration-tests/src/tests/api/profile/social.test.ts | 📈 +8.85 KB |
packages/schemas/src/foundations/jsonb-types/account-center.ts | 📈 +969 Bytes |
wangsijie
force-pushed
the
wangsijie-log-9937-remove-identifier-and-check-sign-up-identifier
branch
from
November 15, 2024 07:32
dee8b57
to
7238be0
Compare
Base automatically changed from
wangsijie-log-9937-remove-identifier-and-check-sign-up-identifier
to
master
November 15, 2024 07:51
wangsijie
force-pushed
the
wangsijie-log-10350-rename-prefix-to-account
branch
from
November 15, 2024 09:48
07b83c5
to
480dece
Compare
wangsijie
force-pushed
the
wangsijie-log-10350-rename-prefix-to-account
branch
3 times, most recently
from
November 18, 2024 01:10
129e714
to
edfa71c
Compare
simeng-li
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wangsijie
force-pushed
the
wangsijie-log-10350-rename-prefix-to-account
branch
from
November 18, 2024 04:27
edfa71c
to
4b82ddb
Compare
wangsijie
force-pushed
the
wangsijie-log-10350-rename-prefix-to-account
branch
from
November 18, 2024 05:39
4b82ddb
to
3182a58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per discussion, rename
/profile
to/account
.Testing
Existing tests should pass.
Checklist
.changeset