Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): rename prefix to account #6814

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

wangsijie
Copy link
Contributor

Summary

Per discussion, rename /profile to /account.

Testing

Existing tests should pass.

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@github-actions github-actions bot added the enhancement Make it better label Nov 15, 2024
Copy link

github-actions bot commented Nov 15, 2024

COMPARE TO master

Total Size Diff 📈 +7.1 KB

Diff by File
Name Diff
packages/core/src/routes/account-center/index.openapi.json 📈 +105 Bytes
packages/core/src/routes/account/constants.ts 📈 +44 Bytes
packages/core/src/routes/account/email-and-phone.ts 📈 +6.42 KB
packages/core/src/routes/account/identities.ts 📈 +3.6 KB
packages/core/src/routes/account/index.openapi.json 📈 +9.35 KB
packages/core/src/routes/account/index.ts 📈 +5.82 KB
packages/core/src/routes/account/middlewares/koa-account-center.ts 📈 +1.02 KB
packages/core/src/routes/account/utils/get-scoped-profile.ts 📈 +3.17 KB
packages/core/src/routes/init.ts 📈 +97 Bytes
packages/core/src/routes/profile/email-and-phone.ts 📈 +6.33 KB
packages/core/src/routes/profile/identities.ts 📈 +3.53 KB
packages/core/src/routes/profile/index.openapi.json 📈 +9.35 KB
packages/core/src/routes/profile/index.ts 📈 +5.72 KB
packages/core/src/routes/profile/middlewares/koa-account-center.ts 📈 +1.02 KB
packages/core/src/routes/profile/utils/get-scoped-profile.ts 📈 +3.17 KB
packages/core/src/routes/swagger/utils/operation-id.ts 0 Bytes
packages/core/src/routes/types.ts 0 Bytes
packages/core/src/routes/verification/index.ts 📈 +106 Bytes
packages/core/src/routes/well-known/well-known.openapi.ts 0 Bytes
packages/integration-tests/src/api/profile.ts 0 Bytes
packages/integration-tests/src/tests/api/account/account-center-reject.test.ts 📈 +3.63 KB
packages/integration-tests/src/tests/api/account/email-and-phone.test.ts ⚠️ 📈 +23.52 KB
packages/integration-tests/src/tests/api/account/index.test.ts ⚠️ 📈 +11.09 KB
packages/integration-tests/src/tests/api/account/social.test.ts 📈 +8.85 KB
packages/integration-tests/src/tests/api/profile/account-center-reject.test.ts 📈 +3.64 KB
packages/integration-tests/src/tests/api/profile/email-and-phone.test.ts 📈 +16.07 KB
packages/integration-tests/src/tests/api/profile/index.test.ts 📈 +11.09 KB
packages/integration-tests/src/tests/api/profile/social.test.ts 📈 +8.85 KB
packages/schemas/src/foundations/jsonb-types/account-center.ts 📈 +969 Bytes

@wangsijie wangsijie force-pushed the wangsijie-log-9937-remove-identifier-and-check-sign-up-identifier branch from dee8b57 to 7238be0 Compare November 15, 2024 07:32
Base automatically changed from wangsijie-log-9937-remove-identifier-and-check-sign-up-identifier to master November 15, 2024 07:51
@github-actions github-actions bot added size/xl and removed size/m labels Nov 15, 2024
@wangsijie wangsijie force-pushed the wangsijie-log-10350-rename-prefix-to-account branch from 07b83c5 to 480dece Compare November 15, 2024 09:48
@github-actions github-actions bot added size/l and removed size/xl labels Nov 15, 2024
@wangsijie wangsijie force-pushed the wangsijie-log-10350-rename-prefix-to-account branch 3 times, most recently from 129e714 to edfa71c Compare November 18, 2024 01:10
Copy link
Contributor

@simeng-li simeng-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangsijie wangsijie force-pushed the wangsijie-log-10350-rename-prefix-to-account branch from edfa71c to 4b82ddb Compare November 18, 2024 04:27
@wangsijie wangsijie force-pushed the wangsijie-log-10350-rename-prefix-to-account branch from 4b82ddb to 3182a58 Compare November 18, 2024 05:39
@wangsijie wangsijie merged commit 4658bd2 into master Nov 18, 2024
35 checks passed
@wangsijie wangsijie deleted the wangsijie-log-10350-rename-prefix-to-account branch November 18, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Make it better size/l
Development

Successfully merging this pull request may close these issues.

2 participants