feat(schemas,core,console): add SAML application type #6766
+271
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/console/src/assets/docs/guides/types.ts | 📈 +29 Bytes |
| packages/console/src/components/ApplicationCreation/CreateForm/Footer/index.tsx | 📈 +83 Bytes |
| packages/console/src/components/ApplicationCreation/CreateForm/index.tsx | 📈 +66 Bytes |
| packages/console/src/components/ApplicationCreation/index.tsx | 📈 +39 Bytes |
| packages/console/src/components/ApplicationIcon/index.tsx | 📈 +47 Bytes |
| packages/console/src/components/AuditLogTable/index.tsx | 📈 +44 Bytes |
| packages/console/src/components/EntitiesTransfer/components/EntityItem/index.tsx | 📈 +39 Bytes |
| packages/console/src/components/Guide/index.tsx | 📈 +6 Bytes |
| packages/console/src/components/ItemPreview/ApplicationPreview.tsx | 📈 +6 Bytes |
| packages/console/src/consts/applications.ts | 📈 +83 Bytes |
| packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/GuideDrawer/index.tsx | 📈 +6 Bytes |
| packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/RefreshTokenSettings.tsx | 📈 +39 Bytes |
| packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/Settings.tsx | 📈 +6 Bytes |
| packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/index.tsx | 📈 +32 Bytes |
| packages/console/src/pages/ApplicationDetails/GuideModal/index.tsx | 📈 +6 Bytes |
| packages/console/src/pages/ApplicationDetails/components/AppGuide/index.tsx | 📈 +6 Bytes |
| packages/console/src/pages/ApplicationDetails/index.tsx | 📈 +39 Bytes |
| packages/console/src/pages/Applications/components/ProtectedAppForm/index.tsx | 📈 +39 Bytes |
| packages/console/src/pages/Applications/components/TypeDescription/index.tsx | 📈 +28 Bytes |
| packages/console/src/pages/Applications/hooks/use-application-data.ts | 📈 +6 Bytes |
| packages/console/src/pages/EnterpriseSsoDetails/IdpInitiatedAuth/ConfigForm.tsx | 📈 +814 Bytes |
| packages/console/src/pages/EnterpriseSsoDetails/IdpInitiatedAuth/index.tsx | 📈 +39 Bytes |
| packages/console/src/pages/EnterpriseSsoDetails/IdpInitiatedAuth/utils.ts | 📈 +38 Bytes |
| packages/console/src/pages/GetStarted/index.tsx | 📈 +39 Bytes |
| packages/console/src/pages/OrganizationDetails/MachineToMachine/AddAppsToOrganization.tsx | 📈 +39 Bytes |
| packages/console/src/pages/OrganizationDetails/MachineToMachine/index.tsx | 📈 +572 Bytes |
| packages/console/src/pages/RoleDetails/RoleApplications/index.tsx | 📈 +39 Bytes |
| packages/console/src/pages/Roles/components/AssignRoleModal/index.tsx | 📈 +39 Bytes |
| packages/console/src/types/applications.ts | 📈 +547 Bytes |
| packages/core/src/routes/applications/application.ts | 📈 +967 Bytes |
| packages/core/src/routes/applications/types.ts | 📈 +744 Bytes |
| packages/integration-tests/src/tests/api/application/application.secrets.test.ts | 📈 +113 Bytes |
| packages/integration-tests/src/tests/api/application/application.test.ts | 📈 +654 Bytes |
| packages/integration-tests/src/tests/console/applications/constants.ts | 📈 +69 Bytes |
| packages/phrases/src/locales/en/errors/application.ts | 📈 +88 Bytes |
| packages/schemas/alterations/next-1731900596-add-saml-application-type.ts | 📈 +1.88 KB |
| packages/schemas/alterations/next-1731900631-add-saml-app-third-party-consistency-check.ts | 📈 +569 Bytes |
| packages/schemas/src/utils/application.ts | 📈 +93 Bytes |
| packages/schemas/tables/applications.sql | 📈 +137 Bytes |
darcyYe
force-pushed
the
yemq-log-10133-add-isVisible-to-applications-table
branch
3 times, most recently
from
b5bb11c
to
81b6722
Compare
darcyYe
changed the title
darcyYe
force-pushed
the
yemq-log-10133-add-isVisible-to-applications-table
branch
2 times, most recently
from
87d77d1
to
d70989d
Compare
darcyYe
force-pushed
the
yemq-log-10133-add-isVisible-to-applications-table
branch
from
f2bec19
to
18837d3
Compare
darcyYe
requested review from
wangsijie,
charIeszhao,
xiaoyijun,
gao-sun and
simeng-li
as code owners
darcyYe
force-pushed
the
yemq-log-10133-add-isVisible-to-applications-table
branch
from
18837d3
to
71193e0
Compare
darcyYe
force-pushed
the
yemq-log-10133-add-isVisible-to-applications-table
branch
from
71193e0
to
f604112
Compare
simeng-li
reviewed
Nov 18, 2024
packages/console/src/components/ApplicationCreation/CreateForm/index.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+270
to
+279
| if (pendingUpdateApplication.type === ApplicationType.SAML) { | ||
| throw new RequestError('application.use_saml_app_api'); | ||
| } |
There was a problem hiding this comment.
How about saml_app_read_only?
There was a problem hiding this comment.
Based on the offline discussions, we are now disabling the GET /applications(/:id)? API for SAML apps. When we need to modify the console, we will then allow the GET /applications/(:id)? API, and at that time, we can change it to saml_app_read_only.
darcyYe
force-pushed
the
yemq-log-10133-add-isVisible-to-applications-table
branch
2 times, most recently
from
fde0600
to
d5c8533
Compare
darcyYe
force-pushed
the
yemq-log-10133-add-isVisible-to-applications-table
branch
from
d5c8533
to
8ede93b
Compare
darcyYe
changed the title
darcyYe
force-pushed
the
yemq-log-10133-add-isVisible-to-applications-table
branch
from
8ede93b
to
3a47e75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add
SAMLapplication type, with following changes:SAMLto enum application typePOST /applicationsandPATCH /applications/:idAPI, also filtered SAML apps fromGET /applications(/:id)?APIsSAMLvalue toapplication.typetype.Testing
Should be covered by integration tests.
Checklist
.changeset