-
-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(schemas,core,console): add SAML application type #6766
Merged
darcyYe
merged 4 commits into
master
from
yemq-log-10133-add-isVisible-to-applications-table
Nov 21, 2024
Merged
feat(schemas,core,console): add SAML application type #6766
darcyYe
merged 4 commits into
master
from
yemq-log-10133-add-isVisible-to-applications-table
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
Name | Diff |
---|---|
packages/console/src/components/ApplicationCreation/CreateForm/index.tsx | 📈 +136 Bytes |
packages/console/src/components/ApplicationIcon/index.tsx | 📈 +186 Bytes |
packages/console/src/components/Guide/hooks.ts | 📈 +289 Bytes |
packages/console/src/components/ItemPreview/ApplicationPreview.tsx | 📈 +244 Bytes |
packages/console/src/consts/applications.ts | 📈 +107 Bytes |
packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/GuideDrawer/index.tsx | 📈 +489 Bytes |
packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/index.tsx | 📈 +240 Bytes |
packages/console/src/pages/EnterpriseSsoDetails/IdpInitiatedAuth/ConfigForm.tsx | 📈 +608 Bytes |
packages/core/src/routes/applications/application.ts | 📈 +526 Bytes |
packages/integration-tests/src/tests/api/application/application.secrets.test.ts | 📈 +113 Bytes |
packages/integration-tests/src/tests/api/application/application.test.ts | 📈 +422 Bytes |
packages/integration-tests/src/tests/console/applications/constants.ts | 📈 +69 Bytes |
packages/phrases/src/locales/en/errors/application.ts | 📈 +88 Bytes |
packages/schemas/alterations/next-1731900596-add-saml-application-type.ts | 📈 +1.88 KB |
packages/schemas/alterations/next-1731900631-add-saml-app-third-party-consistency-check.ts | 📈 +569 Bytes |
packages/schemas/src/utils/application.ts | 📈 +93 Bytes |
packages/schemas/tables/applications.sql | 📈 +137 Bytes |
b5bb11c
to
81b6722
Compare
87d77d1
to
d70989d
Compare
f2bec19
to
18837d3
Compare
18837d3
to
71193e0
Compare
71193e0
to
f604112
Compare
simeng-li
reviewed
Nov 18, 2024
packages/console/src/components/ApplicationCreation/CreateForm/index.tsx
Outdated
Show resolved
Hide resolved
fde0600
to
d5c8533
Compare
d5c8533
to
8ede93b
Compare
8ede93b
to
3a47e75
Compare
gao-sun
reviewed
Nov 21, 2024
3a47e75
to
dcfa9cd
Compare
dcfa9cd
to
d947275
Compare
d947275
to
e47545a
Compare
simeng-li
reviewed
Nov 21, 2024
packages/console/src/components/ApplicationCreation/CreateForm/index.tsx
Outdated
Show resolved
Hide resolved
packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/GuideDrawer/index.tsx
Outdated
Show resolved
Hide resolved
packages/console/src/pages/EnterpriseSsoDetails/IdpInitiatedAuth/ConfigForm.tsx
Outdated
Show resolved
Hide resolved
simeng-li
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
charIeszhao
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add
SAML
application type, with following changes:SAML
to enum application typePOST /applications
andPATCH/DEL /applications/:id
APIsSAML
value toapplication.type
type.Testing
Should be covered by integration tests.
Checklist
.changeset