feat: add phone number validation to user APIs #5882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyYe
force-pushed
the
yemq-log-8880-add-phone-number-validation-to-user-APIs
branch
from
4a854dd to
13d885a
Compare
COMPARE TO
|
| Name | Diff |
|---|---|
| .changeset/big-games-deny.md | 📈 +478 Bytes |
| packages/console/package.json | 📈 +1 Bytes |
| packages/console/src/pages/UserDetails/UserSettings/index.tsx | 📈 +7 Bytes |
| packages/core/package.json | 📈 +36 Bytes |
| packages/core/src/libraries/user.test.ts | 📈 +62 Bytes |
| packages/core/src/libraries/user.ts | 📈 +114 Bytes |
| packages/core/src/queries/user.ts | 📈 +528 Bytes |
| packages/core/src/routes/account/email-and-phone.ts | 📈 +5 Bytes |
| packages/core/src/routes/admin-user/basics.test.ts | 0 Bytes |
| packages/core/src/routes/admin-user/mfa-verifications.test.ts | 📈 +45 Bytes |
| packages/core/src/routes/admin-user/social.test.ts | 0 Bytes |
| packages/core/src/routes/interaction/actions/submit-interaction.test.ts | 0 Bytes |
| packages/core/src/routes/interaction/utils/single-sign-on.test.ts | 0 Bytes |
| packages/core/src/routes/interaction/utils/single-sign-on.ts | 📈 +34 Bytes |
| packages/core/src/utils/user.ts | 📈 +955 Bytes |
| packages/experience/package.json | 📈 +40 Bytes |
| packages/experience/src/utils/country-code.ts | 📈 +158 Bytes |
| packages/experience/src/utils/form.ts | 📈 +16 Bytes |
| packages/integration-tests/src/tests/api/admin-user.search.test.ts | 📈 +89 Bytes |
| packages/integration-tests/src/tests/api/admin-user.test.ts | 📈 +269 Bytes |
| packages/integration-tests/src/tests/api/role.user.test.ts | 📈 +254 Bytes |
| packages/shared/package.json | 0 Bytes |
| packages/shared/src/utils/phone.ts | 📈 +887 Bytes |
| pnpm-lock.yaml | 📈 +346 Bytes |
darcyYe
force-pushed
the
yemq-log-8880-add-phone-number-validation-to-user-APIs
branch
4 times, most recently
from
8a52112 to
af48649
Compare
darcyYe
requested review from
wangsijie,
charIeszhao,
gao-sun and
simeng-li
as code owners
simeng-li
reviewed
May 20, 2024
charIeszhao
approved these changes
May 22, 2024
|
Overall looks good to me. Need to resolve Simeng's comments, though. |
darcyYe
force-pushed
the
yemq-log-8880-add-phone-number-validation-to-user-APIs
branch
2 times, most recently
from
8ca8932 to
b10179e
Compare
|
This PR is stale because it has been open 10 for days with no activity. Remove stale label or comment or this will be closed in 5 days. |
darcyYe
force-pushed
the
yemq-log-8880-add-phone-number-validation-to-user-APIs
branch
3 times, most recently
from
182991a to
c03b7a3
Compare
|
This PR is stale because it has been open 10 for days with no activity. Remove stale label or comment or this will be closed in 5 days. |
darcyYe
force-pushed
the
yemq-log-8880-add-phone-number-validation-to-user-APIs
branch
from
c03b7a3 to
d5ab6b4
Compare
darcyYe
force-pushed
the
yemq-log-8880-add-phone-number-validation-to-user-APIs
branch
3 times, most recently
from
a2081fb to
26c2ccc
Compare
simeng-li
reviewed
Apr 10, 2025
There was a problem hiding this comment.
Copilot reviewed 18 out of 22 changed files in this pull request and generated no comments.
Files not reviewed (4)
- packages/console/package.json: Language not supported
- packages/core/package.json: Language not supported
- packages/experience/package.json: Language not supported
- packages/shared/package.json: Language not supported
simeng-li
reviewed
Apr 10, 2025
packages/core/src/queries/user.ts
Outdated
| @@ -220,7 +223,25 @@ export const createUserQueries = (pool: CommonQueryMethods) => { | |||
| id: string, | |||
| set: Partial<OmitAutoSetFields<CreateUser>>, | |||
| jsonbMode: 'replace' | 'merge' = 'merge' | |||
| ) => updateUser({ set, where: { id }, jsonbMode }); | |||
| ) => { | |||
| if (typeof set.primaryPhone === 'string') { | |||
packages/core/src/queries/user.ts
Outdated
| }); | ||
|
|
||
| const insertUser = async (data: OmitAutoSetFields<CreateUser>) => { | ||
| if (typeof data.primaryPhone === 'string') { |
| return value as ''; | ||
| } | ||
|
|
||
| const result = value.startsWith('+') ? value : `+${value}`; |
There was a problem hiding this comment.
The raw values start with + are not allowed in our DB?
There was a problem hiding this comment.
See packages/shared/src/utils/phone.ts change, this is a legacy logic. But we refactored this.
darcyYe
force-pushed
the
yemq-log-8880-add-phone-number-validation-to-user-APIs
branch
from
3bd5721 to
e6630b4
Compare
darcyYe
force-pushed
the
yemq-log-8880-add-phone-number-validation-to-user-APIs
branch
from
e6630b4 to
685b003
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add phone number validation to user APIs.
insertUserandupdateUserByIdmethods.Testing
Covered by CI.
Checklist
.changeset