Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(schemas): add cloud scope, service log type and API guard #5494

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

darcyYe
Copy link
Contributor

@darcyYe darcyYe commented Mar 12, 2024

Summary

Update schemas for cloud API POST /services/custom-jwt, which includes:

  1. add new cloud scope fetch:custom:jwt, users/machines can access the previously mentioned API with this scope.
  2. add alteration job to assign this fetch:custom:jwt cloud scope to cloud connection m2m app role
  3. add the fetch:custom:jwt scope to DB seed
  4. add service log type, we should log the API call activities with the proper log type.
  5. add API request body guard

Testing

N/A

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@darcyYe darcyYe requested a review from a team March 12, 2024 04:39
Copy link

github-actions bot commented Mar 12, 2024

COMPARE TO master

Total Size Diff 📈 +3.65 KB

Diff by File
Name Diff
packages/cli/src/commands/database/seed/tables.ts 📈 +84 Bytes
packages/schemas/alterations/next-1710223946-add-fetch-custom-jwt-cloud-scope.ts 📈 +2.58 KB
packages/schemas/src/seeds/cloud-api.ts 📈 +382 Bytes
packages/schemas/src/types/jwt-customizer.ts 📈 +582 Bytes
packages/schemas/src/types/logto-config/index.ts 📈 +7 Bytes
packages/schemas/src/types/service-log.ts 📈 +37 Bytes

@darcyYe darcyYe force-pushed the yemq-log-8395-update-logto-schemas branch from 90176d8 to d55a97e Compare March 12, 2024 06:50
@github-actions github-actions bot added size/m and removed size/s labels Mar 12, 2024
@darcyYe darcyYe force-pushed the yemq-log-8395-update-logto-schemas branch 2 times, most recently from f125817 to bc6e9b5 Compare March 12, 2024 07:04
@darcyYe darcyYe force-pushed the yemq-log-8395-update-logto-schemas branch from bc6e9b5 to 733f092 Compare March 12, 2024 07:26
Copy link
Contributor

@simeng-li simeng-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darcyYe darcyYe merged commit 2c7acb2 into master Mar 12, 2024
24 checks passed
@darcyYe darcyYe deleted the yemq-log-8395-update-logto-schemas branch March 12, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants