-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(schemas): update logto_configs
table related types
#5453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
Name | Diff |
---|---|
packages/schemas/src/types/index.ts | 📈 +6 Bytes |
packages/schemas/src/types/logto-config.ts | 📈 +3.88 KB |
packages/schemas/src/types/logto-config/index.ts | 📈 +5.54 KB |
packages/schemas/src/types/logto-config/oidc-provider.ts | 📈 +3.29 KB |
527222c
to
1caf9da
Compare
simeng-li
reviewed
Mar 5, 2024
1caf9da
to
1fd9f8e
Compare
wangsijie
reviewed
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The token is just a simple string?
simeng-li
reviewed
Mar 6, 2024
simeng-li
reviewed
Mar 6, 2024
wangsijie
approved these changes
Mar 7, 2024
simeng-li
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We will support two custom JWT scenarios,
AccessToken
(for end-user) andClientCredentials
(for machine connection), Logto users can customize the logic to manipulate the raw token payload, and the result of the parsed token payload will be further processed by Logto OIDC service and then issued to the client.For each scenario, Logto user can customize the token payload manipulation by providing a code snippet, env variables, and sample token/context (for testing purposes). This is a group of data that will be stored in
logto_config
table as a single DB record.This PR is the preparation for upcoming custom JWT-related APIs, with the following update/refactor:
key
column valueLogtoJwtTokenKey
forlogto_config
table.LogtoJwtTokenKey
, we provide the correspondingdata
guards (jwtCustomizerAccessTokenGuard
andjwtCustomizerClientCredentialsGuard
) and types (JwtCustomizerAccessToken
andJwtCustomizerClientCredentials
).data
guards are optional to make the data flexible. Some fields have default values, but the backend does not care what the value is. The console will handle all of the value fallback logic.Testing
N/A
Checklist
.changeset