refactor(core): remove session api #2878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeng-li
requested review from
a team and
charIeszhao
and removed request for
a team
COMPARE TO
|
| Name | Diff |
|---|---|
| .github/CODEOWNERS | 📉 -56 Bytes |
| packages/core/src/middleware/koa-audit-log-legacy.test.ts | 📉 -4.63 KB |
| packages/core/src/middleware/koa-audit-log-legacy.ts | 📉 -2.94 KB |
| packages/core/src/middleware/koa-log-session-legacy.test.ts | 📉 -2.37 KB |
| packages/core/src/middleware/koa-log-session-legacy.ts | 📉 -814 Bytes |
| packages/core/src/routes/init.ts | 📉 -506 Bytes |
| packages/core/src/routes/session/continue.test.ts | 📉 -7.69 KB |
| packages/core/src/routes/session/continue.ts | 📉 -5.35 KB |
| packages/core/src/routes/session/forgot-password.test.ts | 📉 -8.16 KB |
| packages/core/src/routes/session/forgot-password.ts | 📉 -2.03 KB |
| packages/core/src/routes/session/index.test.ts | 📉 -7.24 KB |
| packages/core/src/routes/session/index.ts | 📉 -3.67 KB |
| packages/core/src/routes/session/middleware/koa-guard-session-action.ts | 📉 -1.7 KB |
| packages/core/src/routes/session/middleware/passwordless-action.ts | 📉 -6.75 KB |
| packages/core/src/routes/session/password.test.ts | 📉 -9.92 KB |
| packages/core/src/routes/session/password.ts | 📉 -5.33 KB |
| packages/core/src/routes/session/passwordless.test.ts | 📉 -31.36 KB |
| packages/core/src/routes/session/passwordless.ts | 📉 -5.44 KB |
| packages/core/src/routes/session/social.bind-social.test.ts | 📉 -6.13 KB |
| packages/core/src/routes/session/social.test.ts | 📉 -13.79 KB |
| packages/core/src/routes/session/social.ts | 📉 -8.93 KB |
| packages/core/src/routes/session/types.ts | 📉 -2.65 KB |
| packages/core/src/routes/session/utils.test.ts | 📉 -11.86 KB |
| packages/core/src/routes/session/utils.ts | 📉 -8.11 KB |
| packages/core/src/routes/types.ts | 📉 -259 Bytes |
| packages/ui/src/apis/social.ts | 📉 -212 Bytes |
|
CI failed |
simeng-li
force-pushed
the
simeng-log-5027-unload-the-session-apis-from-router
branch
from
6e9d065 to
8984bda
Compare
simeng-li
force-pushed
the
simeng-log-5026-clean-up-session-api-integration-tests
branch
from
5b703f3 to
de8582b
Compare
simeng-li
force-pushed
the
simeng-log-5027-unload-the-session-apis-from-router
branch
from
8984bda to
20b61e7
Compare
Base automatically changed from
simeng-log-5026-clean-up-session-api-integration-tests
to
master
January 10, 2023 04:18
simeng-li
force-pushed
the
simeng-log-5027-unload-the-session-apis-from-router
branch
from
20b61e7 to
8ff5fcb
Compare
gao-sun
approved these changes
Jan 10, 2023
wangsijie
approved these changes
Jan 10, 2023
remove session api
remove unused log middlewares
remove session api code owner
simeng-li
force-pushed
the
simeng-log-5027-unload-the-session-apis-from-router
branch
from
d7ddef7 to
9d5fdda
Compare
simeng-li
deleted the
simeng-log-5027-unload-the-session-apis-from-router
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
remove session APIs
Testing
test locally