fix(ui): add sandbox props to iframe (#1757)

add sandbox props to iframe
logto-io · Aug 10, 2022 · 62d2afe · 62d2afe
1 parent ba50de5
commit 62d2afe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/packages/ui/src/components/ConfirmModal/IframeConfirmModal.tsx b/packages/ui/src/components/ConfirmModal/IframeConfirmModal.tsx
@@ -1,5 +1,3 @@
-// FIXME: @simeng
-/* eslint-disable react/iframe-missing-sandbox */
 import classNames from 'classnames';
 import { useState } from 'react';
 import { useTranslation } from 'react-i18next';
@@ -37,6 +35,7 @@ const IframeConfirmModal = ({
         <div className={styles.content}>
           {isLoading && <LoadingIcon />}
           <iframe
+            sandbox={undefined}
             className={isLoading ? styles.hidden : undefined}
             role="iframe"
             src={url}
@@ -64,4 +63,3 @@ const IframeConfirmModal = ({
 };
 
 export default IframeConfirmModal;
-/* eslint-enable react/iframe-missing-sandbox */
diff --git a/packages/ui/src/include.d/dom.d.ts b/packages/ui/src/include.d/dom.d.ts
@@ -73,7 +73,7 @@ type AutoCompleteType =
   | 'tel-country-code'
   | 'tel-national';
 
-// TODO: @simeng remove me
+// LOG-2893 should remove this once we have API response guard
 interface Body {
   json<T>(): Promise<T>;
 }