Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dart): remove the access_token if is expired #19

Merged
merged 3 commits into from
Oct 8, 2022

Conversation

simeng-li
Copy link
Contributor

Summary

remove the access_token if is expired

Testing

ut case added
@logto-io/eng @logto-io/mandatory-reviewers cc: @julian-hartl

@linear
Copy link

linear bot commented Sep 30, 2022

Copy link
Contributor

@julian-hartl julian-hartl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Next step would be to automatically renew the access token once it is expired, right?

lib/src/modules/token_storage.dart Outdated Show resolved Hide resolved
remove the access_token from the storage if it is expired
@simeng-li simeng-li merged commit d0cf6e5 into master Oct 8, 2022
@simeng-li simeng-li deleted the simeng-log-4292 branch October 8, 2022 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants