Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dart): update the token storage to store a map of access token instance #17

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

simeng-li
Copy link
Contributor

Summary

This PR includes the following updates:

  1. Create a new AccessToken interface that includes token, scope, and expiresAt props.
  2. Refactor the TokenStorage access token storage type as a map of the AccessToken instance, using scope + resource as their keys. In order to support multiple resource audience access token storage.
  3. The AccessToken map data will be serialized into a string for FlutterSecureStorage.
  4. Reorg the utility folder, and extract some of the classes as modules, for better management.

Testing

UT case updated
@logto-io/eng @logto-io/mandatory-reviewers cc: @julian-hartl @JulianHartl

…oken instance

update the token storage to storage a map of access token instance
@linear
Copy link

linear bot commented Sep 29, 2022

@simeng-li simeng-li requested review from a team, wangsijie and charIeszhao and removed request for a team September 29, 2022 03:14
lib/logto_client.dart Outdated Show resolved Hide resolved
@simeng-li simeng-li changed the title refactor(dart): update the token storage to storage a map of access token instance refactor(dart): update the token storage to store a map of access token instance Sep 29, 2022
@simeng-li simeng-li merged commit 93cda90 into master Sep 29, 2022
@simeng-li simeng-li deleted the simeng-log-4263 branch September 29, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants