Resolve 413 Payload Too Large #786
Conversation
…ulk_bytes, which is also changed from constant to attribute. solving #785
|
I have submitted the CLA (twice) but I have still not got the mail I'm supposed to get. As for the integration tests I don't think the remaining failures are related to my changes. If they are I need some pointers as to how they could be. If any additional tests are needed for the change I've made I'll try to fix that, but I'd like my suggested fix to reviewed first so I don't do it in vain. |
|
Isn't the simplest way forward on this to just change the batch size to be smaller batches instead of changing a bunch of code? Batch size is configurable to send smaller batches, which would also effectively address this, would it not? |
|
Yeah, but wasn't there a point in the current setting? And of course there could be lower settings in the wild than what AWS uses. |
|
Anyway, just lowering the number to something safely lower than 10MB would be fine with me, but preferably somebody else should do it since signing the CLA doesn't work now. |
|
Now the CLA form worked, so CLA is signed. |
|
Thanks for the PR, this one has fallen a bit into dust. Since a better functionality is already available (since 10.8.6) where payload is split into batches using the uncompressed size (#972). |
If we get a http status 413 on a bulk request we try halfing target_bulk_bytes, which is also changed from constant to attribute.
solving issue #785