Skip to content

Patches for 1x #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Jun 29, 2016

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

@jsvd
Copy link
Member Author

jsvd commented Jun 29, 2016

still getting a failure on es 2.2 and 5.x:

Failures:
  1) Update actions when using script should increment a counter with event/doc 'count' variable with indexed script
     Failure/Error: insist { r["_source"]["counter"] } == 5
     Insist::Failure:
       Expected 5, but got 1
     # ./vendor/bundle/jruby/1.9/gems/insist-1.0.0/lib/insist/assert.rb:8:in `assert'
     # ./vendor/bundle/jruby/1.9/gems/insist-1.0.0/lib/insist/comparators.rb:14:in `=='
     # ./spec/integration/outputs/update_spec.rb:146:in `(root)'
     # ./vendor/bundle/jruby/1.9/gems/rspec-wait-0.0.8/lib/rspec/wait.rb:46:in `(root)'

@dchauviere
Copy link
Contributor

@jsvd, see https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/447/files#diff-9b32fc088ff20e195f304eb97b52a2cfL13, I correct this on master branch with PR #437, only 1st parameter is passed to elasticsearch !

@jsvd jsvd force-pushed the patches_for_1x branch from 2c8f003 to be8af3e Compare June 29, 2016 11:46
@jsvd jsvd mentioned this pull request Jun 29, 2016
@ph
Copy link
Contributor

ph commented Jun 29, 2016

LGTM

@elasticsearch-bot
Copy link

João Duarte merged this into the following branches!

Branch Commits
plugin-api-v1 48c8075, 350d004, be2f678

elasticsearch-bot pushed a commit that referenced this pull request Jun 29, 2016
@jsvd jsvd closed this Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants