Remove deprecated config for 5.0 #432
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -124,9 +112,6 @@ def self.included(mod) | |||
| # Create a new document with source if `document_id` doesn't exist in Elasticsearch | |||
| mod.config :doc_as_upsert, :validate => :boolean, :default => false | |||
|
|
|||
| # DEPRECATED This setting no longer does anything. It will be marked obsolete in a future version. | |||
| mod.config :max_retries, :validate => :number, :default => 3 | |||
There was a problem hiding this comment.
This should be marked :obsolete => "This setting no longer does anything and has been removed. Remove it from your configuration."
Because it's currently labeled deprecated, we should mark it obsolete before removing it completely.
|
@wiibaa would you be able to rebase and factor in @jordansissel 's comments? I'd love to merge this in! Thanks for all the hard work. I've been a bit delayed trying to get #390 in, but now its finally in master! |
wiibaa
force-pushed
the
remove-deprecated
branch
from
e808fc4 to
0c6bf19
Compare
|
@andrewvc done |
|
Thanks so much @wiibaa , merging and releasing :) |
|
Andrew Cholakian merged this into the following branches!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta issue => elastic/logstash#3858