Fix #239 - interpolated action "update" don't get params "upsert" and…

[dchauviere]

This PR fixes a bug (issue #239) in case of interpolated action "update" where specific parameters 'upsert' and 'script' was not set !

[elasticsearch-release]

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

[suyograo]

@dchauviere @Da-wei looks like you used a new GitHub account, so the CLA system did not recognize you. Can you please resign the CLA with this account "@dchauviere"

[dchauviere]

@suyograo, I have signed the CLA. Is there a delay before check pass ?

[suyograo]

@dchauviere all good now :)

[dchauviere]

Thanks @suyograo, its better :)
travis-ci's build seems to randomly fail :

• previous build failed for ES1.7.5 but succeed for ES2.2.0
• last build failed for ES2.2.0 but succeed for ES1.7.5

I will try to reproduce ...

[sir4ur0n]

Hi folks,

Is there any progress on this PR please? The issue still happens in Logstash 2.3.2 :'(

Thank you for your contributions!

[dchauviere]

@sir4ur0n @suyograo, with my previous comment, I think we should wait for #437 to be closed before this can be merged, but I have finished to work on it.

[phoenixgao]

@dchauviere #437 has been closed for one year, is this going to be merged?

Logshash 5.4.2 still has this issue

[ItamarBenjamin]

Hi can someone get this merged please? this bug is really problematic for many developers...

[dchauviere]

@suyograo @andrewvc, do you expect anything from me for merging this ?
Should I rebase with master branch ?

[andrewvc]

@dchauviere apologies for the delay, I've put it at the top of my todo list tomorrow

[rjsaran]

@andrewvc Any plan to merge this in near future.

[dchauviere]

@guyboertje my editor seems to cleanup unneeded space, if its a problem for merging (or just reading changes), I can restore them

[guyboertje]

No need to worry in this case.

[dchauviere]

@guyboertje, could you review that your comments in #732 are well integrated here.

[guyboertje]

LGTM

[guyboertje]

Tests pass. Good to go.

[ItamarBenjamin]

Guys thanks for getting this merged! any idea when the next release is due?