Doc changes #352
Merged
Doc changes #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional troubleshooting section for jdbc driver loading, and remove confusing language about mixins.
Contributor
|
Do you think the note might get more attention here: https://www.elastic.co/guide/en/logstash/current/plugins-inputs-jdbc.html#_drivers Maybe we can keep the note where you think best, and reference it from the other location if you think that's appropriate. |
Member
Author
|
@karenzone Should we move the notes up to the section you suggested, or have the information repeated? |
Contributor
|
What about adding something like "See the |
karenzone
approved these changes
Oct 22, 2019
Contributor
karenzone
left a comment
karenzone
left a comment
There was a problem hiding this comment.
Builds cleanly and LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional troubleshooting section for jdbc driver loading and remove confusing language about mixins.