Make usage of the new stop methodology #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
|
EDITED: nevermind, tests pass |
|
@jsvd should update to stoppable_sleep yes. |
|
@jsvd done in https://github.com/purbon/logstash-input-exec/commit/5c088bd852c32731009e4e955e44ae65fded1a86 thanks for your feedback. |
| queue << event | ||
| end | ||
| out.close | ||
| rescue Exception => e |
There was a problem hiding this comment.
any reason to catch Exception instead of StandardError? (just doing rescue => e)
|
I'd prefer not to have the refactoring done in e8bf7d8, but otherwise LGTM [edit] please squash before merge |
…roject Make the command interrumpible by closing the stream, also introduced some small refactoring to pull things into their own methods and out of the main run. make usage of Stud.stoppable_stop to actually stop even if the thread is sleeping
|
Merged sucessfully into master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
stopto return fromrunaccording to elastic/logstash#3210Depends on elastic/logstash-devutils#32 and elastic/logstash#3895