Use empty result when location is nil #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| end | ||
|
|
||
| context "when IP is IPv6 format for localhost" do | ||
| # regression test for issue https://github.com/logstash-plugins/logstash-filter-geoip/issues/51 |
| @tag_on_failure.each{|tag| event.tag(tag)} | ||
| end | ||
|
|
||
| def set_data(event, geo_data = {}) |
There was a problem hiding this comment.
is this method necessary?
maybe a better approach is to have a geo_data object that is instantiated with Hash.new and then gets populated by the above populate_data method.
There was a problem hiding this comment.
Hmm, i thought I can dry up usages like here: https://github.com/logstash-plugins/logstash-filter-geoip/pull/73/files#diff-0ceaeedc6497c6d61fa5ae1d2db1dc58R173
There was a problem hiding this comment.
Also makes it easier when Java Event API work needs to be done :)
|
@talevy let me know if this is better |
| @@ -174,7 +174,7 @@ | |||
| end | |||
|
|
|||
| it "should not have added any tags" do | |||
There was a problem hiding this comment.
new behavior not in sync with test name?
There was a problem hiding this comment.
oh crap, let me change
|
@talevy updated |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some IPs location and most fields are nil. Its better to return empty geoip than Elasticsearch barfing with mapping errors.
Also added tests for IPv6 now that GeoIP2 supports it
Fixes #70