Skip to content

chore: bump logos-protocol to master (nested-bytes qvariantToNlohmann fix #23)#162

Merged
dlipicar merged 1 commit into
masterfrom
chore/repin-protocol-23
Jul 17, 2026
Merged

chore: bump logos-protocol to master (nested-bytes qvariantToNlohmann fix #23)#162
dlipicar merged 1 commit into
masterfrom
chore/repin-protocol-23

Conversation

@dlipicar

Copy link
Copy Markdown
Collaborator

Re-pins logos-protocol → master d5ba950, pulling in logos-protocol#23.

This is the key carrier for the host-side runtime fix: the ModuleProxy that bridges a call to a cdylib module lives here, and it runs qvariantToNlohmann on the (container-valued) call arguments. Before #23 a nested QByteArray was flattened to a plain string, so a bstr argument reached a Rust cdylib as "hello" and decoded to an empty Vec (e.g. echoBytes returned null). After the bump the tag survives and the bytes round-trip.

cpp-sdk/qt-sdk inputs follow this protocol bump; builds clean locally. Downstream hosts (logoscore-cli, standalone-app, basecamp) will pin this re-pinned liblogos next.

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings July 17, 2026 23:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown

📊 liblogos doc-test report

The real accounts module, run through a logoscore daemon built against this commit of liblogos — rendered alongside the commands actually run and their output (updated each run, commit c69271e):

Pages can take a minute to update after the run finishes.

@dlipicar
dlipicar merged commit 8ebb808 into master Jul 17, 2026
4 checks passed
@dlipicar
dlipicar deleted the chore/repin-protocol-23 branch July 17, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants