Cherry-pick of get-input PR #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papertowel123
requested review from
HovorunB,
andriimaistruk and
jplapp
as code owners
papertowel123
changed the title
HovorunB
approved these changes
Jan 16, 2024
jplapp
reviewed
Jan 19, 2024
| nav2_util::declare_parameter_if_not_declared( | ||
| node_, "goal_reached_tol", | ||
| rclcpp::ParameterValue(0.25)); | ||
| node_->get_parameter_or<double>("goal_reached_tol", goal_reached_tol_, 0.25); |
There was a problem hiding this comment.
@maksymdidukh you can keep this, but you need to move all getInput from the constructor to the initialize function.
This is what you did in all other steps as well, right? So you just missed the getInputs here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Base PR link: ros-navigation#3988