Full support for shared model registry #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o-alex
approved these changes
Nov 1, 2021
|
Fixes #11 |
robzor92
force-pushed
the
11
branch
2 times, most recently
from
4d1b911 to
daffe0d
Compare
o-alex
approved these changes
Nov 11, 2021
robzor92
force-pushed
the
11
branch
2 times, most recently
from
b204943 to
db0f29c
Compare
fix fix fix registry id setter fix fix Move filter to snake case annotation add prints add modelregistries resource fix fix
o-alex
reviewed
Nov 18, 2021
python/hsml/engine/model_engine.py
Outdated
| sleep_seconds = 5 | ||
| for i in range(int(await_registration / sleep_seconds)): | ||
| try: | ||
| print(model_instance.shared_registry_project_name) |
There was a problem hiding this comment.
do you need these print statements? If yes should be logged into a more detailed way that the user can interprete?
o-alex
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.