Skip to content

[FSTORE-1721][4.2] Creating training data with time series split fails when setting event_time =True when event_time is not explicitly selected in the query #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: branch-4.2
Choose a base branch
from
Open

[FSTORE-1721][4.2] Creating training data with time series split fails when setting event_time =True when event_time is not explicitly selected in the query #528

wants to merge 1 commit into from

Conversation

manu-sj
Copy link
Contributor

@manu-sj manu-sj commented Apr 4, 2025 •
edited by Maxxx-zh
Loading

This PR cherry-pick changes done in PR : #527

JIRA Issue: https://hopsworks.atlassian.net/browse/FSTORE-1721

Priority for Review: -

Related PRs:
https://github.com/logicalclocks/loadtest/pull/558

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@manu-sj
[FSTORE-1721] Creating training data with time series split fails whe…
97af2ad 
…n setting `event_time =True` when event_time is not explicitly selected in the query (logicalclocks#527)

* using fully qualified names to create a time series split when the event time is not explicilty selected by the user in the feature view query and using fully qualified name when required while checking ambigeous features

* fixing unit tests

* adding tests for _get_fully_qualified_feature_name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@manu-sj