Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme for consistency #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jondkelley
Copy link

@jondkelley jondkelley commented Jan 20, 2021

Making slight modifications for better consistency across the doc

  • Removing quotes from readme. Quotes in cases like docker-compose are provided as literals and invalidate the config. Quotes are also only necessary in YaML if it will create type-aware objects such as integers or arrays.
  • Removing quotes from bash commands as they're not really required unless the value has spaces.
  • Removing single quotes from image name, not necessary.

Copy link

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jondkelley I am really not sure why those quotation marks were ever even there, single or double.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants