Log 11792 journal toggle #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhokhlov
reviewed
Dec 16, 2022
dkhokhlov
reviewed
Dec 20, 2022
|
This Looks good to me apart from the disabled linting, we'll need to fix that before we can get this merged |
dkhokhlov
previously requested changes
Dec 20, 2022
dkhokhlov
reviewed
Dec 20, 2022
stsantilena
reviewed
Dec 21, 2022
stsantilena
reviewed
Dec 21, 2022
stsantilena
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug(journal_toggle): Wrap task spawning in more conditions including new env variable
Summary: added new environment variable MZ_SYSTEMD_JOURNAL_TAILER
If user explicitly sets that to false, no matter if there is a journal path no tasks will spawn
Test plan:
Manually testing
unit tests
Int tests
Ref: LOG-11792