tweak resolve_valid_paths not to return directories #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-nixon
force-pushed
the
LOG-14748-app-name-and-_file-incorrect-when-symlink-alias-present
branch
from
a01997b to
add17b3
Compare
stsantilena
reviewed
Nov 10, 2022
| .iter() | ||
| { | ||
| .filter_map(|path: PathBuf| { | ||
| fs::read_dir(&path).ok().map(|entries| { |
There was a problem hiding this comment.
Is "entries" referring to filename, or SlopMap "entries"?
There was a problem hiding this comment.
Sorry, bad name it's the directory entries from read_dir
stsantilena
approved these changes
Nov 10, 2022
c-nixon
force-pushed
the
LOG-14748-app-name-and-_file-incorrect-when-symlink-alias-present
branch
7 times, most recently
from
f72c7f5 to
35f93fb
Compare
Use seperate target_dirs for each integration test
c-nixon
force-pushed
the
LOG-14748-app-name-and-_file-incorrect-when-symlink-alias-present
branch
from
35f93fb to
fb06491
Compare
c-nixon
force-pushed
the
LOG-14748-app-name-and-_file-incorrect-when-symlink-alias-present
branch
from
e6871cf to
0163a16
Compare
c-nixon
deleted the
LOG-14748-app-name-and-_file-incorrect-when-symlink-alias-present
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some additional logic to the fs cache in order to make sure the resolve_valid_paths function never returns a directory. This fix exposed a bug in the FS initialisation logic which caused files not to be added