Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove start_datetime and end_datetime as required args, fix bug limiting amount of searches to 10k events #959

Merged
merged 4 commits into from
Jan 21, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix: Remove trailing whitespace
  • Loading branch information
itsmvd committed Jan 21, 2025
commit b1daa8f32d8da546c21575bbd89cc7ce62ee5826
2 changes: 1 addition & 1 deletion dftimewolf/lib/collectors/timesketch.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def _GetSearchResults(self) -> pd.DataFrame:
else:
label_chip.label = label
search_obj.add_chip(label_chip)

# Timesketch API returns a max of 10000 results by default
if search_obj.expected_size > 10000:
search_obj.max_entries = search_obj.expected_size + 1
Expand Down
Loading