Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TimesketchEvents container to containers.py #952

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

itsmvd
Copy link
Collaborator

@itsmvd itsmvd commented Jan 14, 2025

No description provided.

@itsmvd itsmvd marked this pull request as ready for review January 14, 2025 13:28
@itsmvd itsmvd requested a review from tomchop January 14, 2025 13:28
tomchop
tomchop previously approved these changes Jan 14, 2025
@@ -4,6 +4,7 @@
from __future__ import annotations

import datetime
import pandas as pd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove import from the TYPE_CHECKING block

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Fix pandas -> pd
fix import order
@tomchop tomchop merged commit 8027db9 into log2timeline:main Jan 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants