Refactored validators into separate files #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchop
requested changes
Jun 6, 2024
| # Source: https://cloud.google.com/compute/docs/regions-zones/ | ||
| # Fetched 2023-01-13 | ||
| # TODO - Fetch at runtime? | ||
| _zones = { |
There was a problem hiding this comment.
Should we make this a module-level constant now that it's in its own module?
There was a problem hiding this comment.
Same comment for other modules that have similar attributes.
|
|
||
|
|
||
| @classmethod | ||
| def RegisterValidator( |
There was a problem hiding this comment.
Other manages have a boolean parameter that allows for overwriting validators (useful if we have different internal validation logic)
There was a problem hiding this comment.
Added an override argument here
tomchop
approved these changes
Jun 7, 2024
wajihyassine
pushed a commit
to wajihyassine/dftimewolf
that referenced
this pull request
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ease of viewing and isolating