Skip to content

Conversation

someguyiknow
Copy link
Collaborator

Could also just as easily replace the elif with else, as makedirs would make any missing ones.

Could also just as easily replace the elif with else, as makedirs would make any missing ones.
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #322 into master will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
- Coverage   79.19%   79.15%   -0.05%     
==========================================
  Files          29       29              
  Lines        1908     1909       +1     
==========================================
  Hits         1511     1511              
- Misses        397      398       +1     
Impacted Files Coverage Δ
dftimewolf/lib/exporters/local_filesystem.py 83.33% <0.00%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ddaad0...226e16f. Read the comment docs.

@someguyiknow someguyiknow requested a review from tomchop August 13, 2020 16:16
@tomchop tomchop merged commit 07cdd31 into log2timeline:master Aug 17, 2020
tomchop pushed a commit to aarontp/dftimewolf that referenced this pull request Oct 24, 2020
Could also just as easily replace the elif with else, as makedirs would make any missing ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants