Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Ruby quickstart #739

Merged
merged 3 commits into from
Oct 16, 2023
Merged

feat: add Ruby quickstart #739

merged 3 commits into from
Oct 16, 2023

Conversation

Aunali321
Copy link
Contributor

Closes #373
image

DevPod uses microsoft/vscode-try-remote-* images for quickstart guides. But Microsoft does not provide any images for Ruby. So i made my own image https://github.com/Aunali321/ruby-quickstarter-template for this PR. I recommend DevPod team to fork the image to loft-sh repo so you don't have to be dependent on me.

@pascalbreuninger
Copy link
Member

Hi @Aunali321, thanks for your PR!
I'm not a fan of how it looks now, would need to revisit it. What do you think of having a more popover where we can show other quickstarts?
This way we keep the original first party supported quickstarts but also allow for community contributions

@Aunali321
Copy link
Contributor Author

Hi @Aunali321, thanks for your PR! I'm not a fan of how it looks now, would need to revisit it. What do you think of having a more popover where we can show other quickstarts? This way we keep the original first party supported quickstarts but also allow for community contributions

Yup that sounds much better. Will be done later today.

@Aunali321
Copy link
Contributor Author

Aunali321 commented Oct 13, 2023

image

image

Is this fine?

@pascalbreuninger
Copy link
Member

Definitely better. I took the liberty to adjust it a bit:
image

If you're okay with degrading .net to community and reusing the community icon I'll merge it

@Aunali321
Copy link
Contributor Author

Looks good to me

@pascalbreuninger pascalbreuninger merged commit 6b46243 into loft-sh:main Oct 16, 2023
1 check passed
@Aunali321
Copy link
Contributor Author

Can you add hacktoberfest accepted label?

@pascalbreuninger
Copy link
Member

sure thing ;)

@Aunali321
Copy link
Contributor Author

sure thing ;)

It's not being picked up by hacktoberfest website. I am pretty sure it needs to be hacktoberfest-accepted label

@pascalbreuninger
Copy link
Member

Ah wasn't aware of that, updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add Ruby as a quickstart
2 participants