-
-
Notifications
You must be signed in to change notification settings - Fork 42
feat: use .ls-lint.yaml file as default configuration file #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@loeffel-io any hope you would review this PR ? Thanks |
|
LGTM, i think this will make it into 2.4.0 for sure Really looking forward to find more time for ls-lint but currently my real job is too time consuming |
loeffel-io
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can easily remove the comments and consts please and then its good to go
background: the legacy config file will be deprecated and removed anyways in a period of time
|
@loeffel-io I simplified things |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request changes the default configuration file from .ls-lint.yml to .ls-lint.yaml while maintaining backward compatibility. The change aligns with YAML file naming conventions that prefer the .yaml extension.
Key Changes:
- Modified config file detection logic to prioritize
.ls-lint.yamlover.ls-lint.yml - Updated documentation to reflect the new default while noting backward compatibility
- Added
.ls-lint.yamlconfiguration file to the repository
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/ls_lint/main.go | Implements fallback logic to check for .ls-lint.yaml first, then .ls-lint.yml if the former doesn't exist |
| README.md | Updates documentation to show .ls-lint.yaml as the primary config file format, with .ls-lint.yml noted for backward compatibility; also corrects "unicode" to "Unicode" |
| .ls-lint.yaml | Adds the new default configuration file to the repository |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The .ls-lint.yaml file is now used as the default configuration file The .ls-lint.yml file is still supported for backward compatibility. The choice was made to prioritize the .ls-lint.yaml file for its clarity and alignment with YAML file naming conventions.
The .ls-lint.yaml file is now used as the default configuration file
The .ls-lint.yml file is still supported for backward compatibility.
The choice was made to prioritize the .ls-lint.yaml file for its clarity
and alignment with YAML file naming conventions.
Fixes #328