fix(android): add RootNodeKind trait for nested sheet touch handling#375
Merged
Conversation
Fixes pressables not working in nested sheets on Android real devices. The RootNodeKind trait ensures each sheet has its own coordinate space for touch event routing.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
🚀 This pull request is included in v3.7.0-beta.0. See Release 3.7.0-beta.0 for release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes pressables not working in nested sheets on Android real devices.
The issue was that
TrueSheetViewShadowNodewas missing theRootNodeKindtrait. This trait is used by React Native's Fabric renderer to:computeRelativeLayoutMetrics(), the algorithm stops at nodes withRootNodeKind, treating them as new roots for layout calculationsfindNodeAtPoint(), coordinates are calculated correctly for nested views within their own coordinate spaceWithout this trait, nested TrueSheet components have their coordinates calculated relative to the parent sheet, which causes touch events to be routed incorrectly.
This is the same pattern used by:
ModalHostViewShadowNodeRNSModalScreenShadowNode,RNSFullWindowOverlayShadowNode, andRNSSplitViewScreenShadowNodeFixes #163
Type of Change
Test Plan
Tested nested sheets with pressables on Android real device - pressables now respond correctly.
Checklist