Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing the notOnSame property from template #32

Closed
danjford opened this issue Dec 28, 2015 · 2 comments
Closed

Removing the notOnSame property from template #32

danjford opened this issue Dec 28, 2015 · 2 comments
Labels
enhancement

Comments

@danjford
Copy link
Member

Background

The notOnSame property present on templates is used when you are using the url attribute to make it so that a request isn't executed if you already on that page to start with.

Solution

I think that we can get rid of the notOnSame property all together. If the url in the template Object is different to the previous path visited, then it already knows that it will need to request the template regardless of whether it is already on the page.
@danjford danjford changed the title Removing the notOnSame property from template Changing the notOnSame property from template default Dec 28, 2015
@danjford danjford changed the title Changing the notOnSame property from template default Removing the notOnSame property from template Dec 28, 2015
danjford added a commit that referenced this issue Dec 29, 2015
@danjford
Quickly testing #32
e88048b
danjford added a commit that referenced this issue Dec 29, 2015
@danjford
Solution to #32
1bf66ea 
Have removed the notOnSame property as it was unnecessary.
danjford added a commit to danjford/lodestar-ractive that referenced this issue Jan 7, 2016
@danjford
feat: Removing notOnSame
b5c0851 
lodestarjs#32
@danjford
Copy link
Member Author

danjford commented Jan 7, 2016

Changes have been made on my branch, I will merge it in once tests & coverage has been added.

@danjford
Copy link
Member Author

Enhancement now in latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danjford