-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deposition): improvements and fixes #2960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusroemer
changed the title
Add_authors_to_manifest
feat: ENA deposition improvements and fixes
Oct 7, 2024
corneliusroemer
changed the title
feat: ENA deposition improvements and fixes
feat(deposition): improvements and fixes
Oct 7, 2024
corneliusroemer
force-pushed
the
add_authors_to_manifest
branch
from
October 7, 2024 10:19
c1b346b
to
6212f1a
Compare
anna-parker
commented
Oct 7, 2024
corneliusroemer
added
the
needs-ppx-values-pr
Requires accompanying pathoplexus/pathoplexus PR to update values.yaml
label
Oct 7, 2024
anna-parker
force-pushed
the
add_authors_to_manifest
branch
from
October 7, 2024 13:01
d6f5e0a
to
6fb43f9
Compare
anna-parker
added a commit
to pathoplexus/pathoplexus
that referenced
this pull request
Oct 7, 2024
corneliusroemer
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, save 1-2 comments, have a look at them before merging
So this PR:
- adds the is_broker variable to config
- renames
ingest
toenaDeposition
in some comments - adds the
AUTHORS
manifest row - allows setting different ingest and deposition taxon ids
corneliusroemer
force-pushed
the
add_authors_to_manifest
branch
from
October 7, 2024 15:42
897ca03
to
c4695da
Compare
* Add address # Conflicts: # ena-submission/scripts/create_assembly.py * Fix address parsing * fix tests * fix tests (cherry picked from commit 673786c) * log error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-ppx-values-pr
Requires accompanying pathoplexus/pathoplexus PR to update values.yaml
preview
Triggers a deployment to argocd
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2955
preview URL: https://add-authors-to-manifest.loculus.org
Summary
Screenshot
PR Checklist