Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove '-' from list of allowed symbols in unaligned sequences. #2728

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

anna-parker
Copy link
Contributor

@anna-parker anna-parker commented Sep 9, 2024

resolves #

preview URL: https://no-gaps-in-unaligned.loculus.org/

Summary

'-' only makes sense in the context of aligned sequences. It is not accepted by ENA and is not included in official IUPAC lists: https://genome.ucsc.edu/goldenPath/help/iupac.html#:~:text=The%20International%20Union%20of%20Pure,for%20either%20G%20or%20A).

@anna-parker anna-parker added the preview Triggers a deployment to argocd label Sep 9, 2024
@fengelniederhammer
Copy link
Contributor

I think the backend has the same problem:

enum class NucleotideSymbols(override val symbol: Char) : Symbol {
A('A'),
C('C'),
G('G'),
T('T'),
M('M'),
R('R'),
W('W'),
S('S'),
Y('Y'),
K('K'),
V('V'),
H('H'),
D('D'),
B('B'),
N('N'),
GAP('-'),
}

@anna-parker
Copy link
Contributor Author

anna-parker commented Sep 9, 2024

@fengelniederhammer the backend uses the nucleotide symbol list in the type check: validateNoUnknownNucleotideSymbol which is used for both unaligned and aligned sequences - it is a correct symbol for aligned sequences so I think it is ok to keep the backend as is.

@fengelniederhammer
Copy link
Contributor

Isn't it the same issue? In aligned sequences - should be allowed, in unaligned it is not allowed. We could easily also introduce a new list in the backend that splits the validation.

@anna-parker anna-parker enabled auto-merge (squash) September 9, 2024 13:31
@anna-parker anna-parker merged commit 5c23096 into main Sep 9, 2024
18 checks passed
@anna-parker anna-parker deleted the no_gaps_in_unaligned branch September 9, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants