Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using camelCase for metadata fields #2507

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

anna-parker
Copy link
Contributor

@anna-parker anna-parker commented Aug 22, 2024

resolves #2438

preview URL: https://switch-to-camelcase.loculus.org/

Summary

After a long discussion today we have decided to switch all metadata fields to camelCase to ensure consistency in fields for users.

Screenshot

PR Checklist

  • Download metadata templates and results for all organisms and check this does not contain any snake_case -> confirmed for template downloads (of all organisms), confirmed download is working.
  • Figure out why dummy organism is not loading on preview - wupps:
    image I see the error No data found in /data/ for ingestion which is odd I thought we fixed this on LAPIS => caused by the fact that pango_lineage is a metadata type in LAPIS and pangoLineage is not, I have now fixed this

Future work

…elds in values.yaml and performing search and replace.
@anna-parker anna-parker added the preview Triggers a deployment to argocd label Aug 22, 2024
@theosanderson
Copy link
Member

As I just mentioned in a message to Anna I think we should merge this as soon as it is internally consistent to avoid merge conflicts - it doesn't have to be consistent with pathoplexus and example_data until say tomorrow

@anna-parker anna-parker marked this pull request as ready for review August 22, 2024 18:19
Copy link
Member

@theosanderson theosanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge kudos on this work. I looked through everything and couldn't immediately find problems. I also tried the preview and didn't encounter problems. Obviously I could have missed things

@anna-parker
Copy link
Contributor Author

Ok fingers crossed there are no issues! Sadly this will mean a lot of merge conflicts for everyone else - sorry about that!

@anna-parker anna-parker merged commit 0a55712 into main Aug 22, 2024
19 checks passed
@anna-parker anna-parker deleted the switch_to_camelcase branch August 22, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent metadata field formats
2 participants