feat(deployment): basic http auth for website #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theosanderson
requested review from
chaoran-chen,
corneliusroemer and
anna-parker
|
I really like the idea of having this for the preview instances - how easy would it be to keep this for the preview instances when we go live and remove it for production? |
chaoran-chen
approved these changes
Jun 28, 2024
It could be possible, but it wouldn't really accord with an open source / open development model IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configurable basic HTTP auth for the website only. If a
basicauthsecret is configured, which can be done as shown here (one could also use a sealed secret, one would have to generate its contents withhtpasswdthen seal it).N.B. This does not protect all data, which can still be accessed e.g. with LAPIS or potentially the backend.
This will apply to all preview instances but not to e.g. the pathoplexus demo until configured.
https://auth.loculus.org/
username: loculus
password: widetailpotato