Skip to content

Try to reuse pinned BPF maps #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

vadorovsky
Copy link
Member

@vadorovsky vadorovsky commented Jan 17, 2022

Before this change, each restart of lockc resulted in loss of data in
BPF maps. After this change, data is persistent as long as the host
system is not rebooted. All maps are pinned to BPPFS and lockc attempts
to reuse them if they're present.

Fixes: #130
Signed-off-by: Michal Rostecki mrostecki@opensuse.org

@vadorovsky vadorovsky force-pushed the reuse-pinned-maps branch 2 times, most recently from 473def9 to da714cc Compare January 17, 2022 19:04
@vadorovsky vadorovsky requested review from flavio and mjura January 18, 2022 10:41
@vadorovsky vadorovsky marked this pull request as ready for review January 18, 2022 10:42
Copy link
Collaborator

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a minor comment

Before this change, each restart of lockc resulted in loss of data in
BPF maps. After this change, data is persistent as long as the host
system is not rebooted. All maps are pinned to BPPFS and lockc attempts
to reuse them if they're present.

Fixes: lockc-project#130
Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>
Copy link
Collaborator

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjura
Copy link
Collaborator

mjura commented Jan 21, 2022

I have tested it and works fine

@vadorovsky vadorovsky merged commit 4965941 into lockc-project:main Jan 21, 2022
@vadorovsky vadorovsky deleted the reuse-pinned-maps branch January 21, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating lockc with custom lockc.toml causes problems
3 participants