GEOMESA-445 Create Temporal Density Iterator #346
Conversation
| else if(isTemporalDensity){ | ||
| val q1 = new Query(featureType.getTypeName) | ||
| Iterator(DataUtilities.mixQueries(q1, query, "geomesa.mixed.query")) | ||
| } else { | ||
| splitQueryOnOrs(query, output) | ||
| } |
There was a problem hiding this comment.
A case statement here may be much cleaner, rather than the if/else logic.
There was a problem hiding this comment.
I'm having a hard time figuring out how to make this look best with a case statement because there are multiple booleans being checked.
So far I've come up with this style:
val a = (true/false)
val b = (true/false)
val queries = true match {
case a => "Do something"
case b => "Do something else"
case true => "Do default"
}
Is this any cleaner than the current state of code?
|
What I've seen so far looks nice. However I have not been able to look at TimeSnap nor the TemporalDensityIterator yet. |
| val featureBuilder = AvroSimpleFeatureFactory.featureBuilder(returnSFT) | ||
| featureBuilder.reset() | ||
| featureBuilder.add(TemporalDensityIterator.encodeTimeSeries(summedTimeSeries)) | ||
| featureBuilder.add(WKTUtils.read("Point(0 0)")) //BAD BAD BAD BAD BAD OKAY |
There was a problem hiding this comment.
Funny comments almost always require more length explanations. I assume this is done since you're dealing with only time information, yet need some kind of geometry for the Feature. If this is correct, please add a comment to this effect.
There was a problem hiding this comment.
Also, use a static constant rather than calling WKTUtils.read each time.
…poralDensityIterator
|
Merged as 4965b42 on 1.5. |
No description provided.