Add unit tests to ensure ingest from stdin works correctly when inferring various converters
There are unit tests in the IngestCommandTest class that indirectly call the DelimitedTextConverterFactory.infer(is: InputStream+, sft: OptionSimpleFeatureType, path: OptionString) function, whose path argument is unused. As a result, the tests pass regardless of the value of the path argument.
There are other converter factory classes with their own infer function (e.g. ParquetConverterFactory) that actually use this path argument. It might be helpful to add more unit tests to the IngestCommandTest class to ensure that the ingest works with other converters' inference.
Original JIRA Issue: https://geomesa.atlassian.net/browse/GEOMESA-3328
Key: GEOMESA-3328
Type: Improvement
Priority: Major
Status: To Do
Resolution: Unresolved
Reporter: Adeet Patel
Created: Thu, 25 Jan 2024 13:49:19 -0500
Updated: Thu, 25 Jan 2024 14:03:01 -0500
Related Issues:
- Relates (is depended on by): GEOMESA-3326
Comments:
712020:0d239501-a76e-446a-9f68-cd9eb8f2bbfe (Thu, 25 Jan 2024 14:03:01 -0500):
Created from #3036 (comment)
Add unit tests to ensure ingest from stdin works correctly when inferring various converters
There are unit tests in the IngestCommandTest class that indirectly call the DelimitedTextConverterFactory.infer(is: InputStream+, sft: OptionSimpleFeatureType, path: OptionString) function, whose path argument is unused. As a result, the tests pass regardless of the value of the path argument.
There are other converter factory classes with their own infer function (e.g. ParquetConverterFactory) that actually use this path argument. It might be helpful to add more unit tests to the IngestCommandTest class to ensure that the ingest works with other converters' inference.
Original JIRA Issue: https://geomesa.atlassian.net/browse/GEOMESA-3328
Key: GEOMESA-3328
Type: Improvement
Priority: Major
Status: To Do
Resolution: Unresolved
Reporter: Adeet Patel
Created: Thu, 25 Jan 2024 13:49:19 -0500
Updated: Thu, 25 Jan 2024 14:03:01 -0500
Related Issues:
Comments:
712020:0d239501-a76e-446a-9f68-cd9eb8f2bbfe (Thu, 25 Jan 2024 14:03:01 -0500):
Created from #3036 (comment)