Skip to content

Allow more flexibility for lambda hot-reloading paths #7345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Dec 16, 2022

Motivation

We want to be able to watch arbitrary paths to allow hot reload, for more advanced features, like layer hot reloading.

Changes

  • Update LRI to v0.1.8-pre to get support for specifying arbitrary paths to be watched for changes (and reloading after a change)
  • Skip the whole test class instead of just a test, as it seems to fit better for the functionality

Depends on localstack/lambda-runtime-init#8

@dfangl dfangl temporarily deployed to localstack-ext-tests December 16, 2022 18:29 — with GitHub Actions Inactive
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

github-actions bot commented Dec 16, 2022

LocalStack integration with Pro

       1 files   -     2         1 suites   - 2   1h 20m 55s ⏱️ -14s
1 554 tests  -   16  1 267 ✔️  -   33  280 💤 +  10  7 +7 
1 554 runs   - 654  1 267 ✔️  - 401  280 💤  - 260  7 +7 

For more details on these failures, see this check.

Results for commit 969699f. ± Comparison against base commit 2eeac6e.

♻️ This comment has been updated with latest results.

@dfangl dfangl force-pushed the hot-reloading-update branch from ec12ac8 to 969699f Compare December 16, 2022 21:37
@dfangl dfangl temporarily deployed to localstack-ext-tests December 16, 2022 21:37 — with GitHub Actions Inactive
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 84.883% when pulling 969699f on hot-reloading-update into 2eeac6e on master.

@dfangl dfangl merged commit 1b92e61 into master Dec 19, 2022
@dfangl dfangl deleted the hot-reloading-update branch December 19, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants