Skip to content

Add an initial draft for test utilities #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 27, 2024
Merged

Add an initial draft for test utilities #11

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f77878f
wip
giograno Nov 15, 2024
1471102
added decorator to load a pod + a small fixture to reset the state
giograno Nov 15, 2024
bf1e5d7
minor
giograno Nov 15, 2024
4b28481
Update localstack-sdk-python/localstack/sdk/testing/decorators.py
giograno Nov 27, 2024
66ea64e
Update tests/testing/test_decorators.py
giograno Nov 27, 2024
e4db65c
use of a test util
giograno Nov 27, 2024
75b6b71
minor
giograno Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
minor
  • Loading branch information
@giograno
giograno committed Nov 27, 2024
commit 75b6b71cf8542fd0cb84937ea2fce5e55cd3bf08
2 changes: 1 addition & 1 deletion tests/integration/test_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import pytest

from localstack.sdk.state import StateClient
from utils import boto_client
from tests.utils import boto_client


class TestStateClient:
Expand Down
2 changes: 1 addition & 1 deletion tests/testing/test_decorators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from localstack.sdk.pods import PodsClient
from localstack.sdk.state import StateClient
from localstack.sdk.testing import cloudpods
from utils import boto_client
from tests.utils import boto_client

DECORATOR_POD_NAME = "ls-sdk-pod-decorator"
QUEUE_NAME = "ls-decorator-queue"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be a good idea to use names with a random element, or perhaps handle exceptions in fixture teardowns

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea was to simply keep pushing on the same pod which simply creates a new version. This way we don't have to think about randomness or exceptions.

Expand Down