-
Notifications
You must be signed in to change notification settings - Fork 128
Conversation
|
Deploy PR Preview failed. |
|
|
||
| #### Configurations | ||
|
|
||
| The following environment variables can be configured: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: are these config options for CDK Local or LocalStack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are configs for cdklocal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm, on a second thought, I think that these configurations are too much. I just can put a link to the GitHub documentation for additional information. wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good idea 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done! Let me know what you think :).
viren-nadkarni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ✔️
I believe that this should be on our aws-cdk-local's public documentation. Currently, this information it's hard to find and we're seeing multiple tickets on supports related to this specific use case.