migrate rds failover sample to pro samples #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@HarshCasper: I added @baermat as reviewer as he is the code owner of the pro-samples. To me everything looks fine, but I am not sure if for the automated CI the Makefile needs to a follow a special pattern. @baermat can hopefully give some input here 🙏 |
baermat
approved these changes
Jan 26, 2024
Contributor
baermat
left a comment
baermat
left a comment
There was a problem hiding this comment.
LGTM 👍 and sorry for the delay
related: I seem to have lost access rights with the move the new org, please give localstack core access :)
Contributor
@baermat added the localstack-engineers as maintainers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.