This repository was archived by the owner on Jan 7, 2025. It is now read-only.
Form element description position #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Form element description can appear before or after the input item. At the moment, only the *after* position is supported. Fixed now.
Adnan-cds
requested review from
andybroomfield,
cjstevens78,
danchamp and
finnlewis
finnlewis
approved these changes
Jun 8, 2021
Member
finnlewis
left a comment
finnlewis
left a comment
There was a problem hiding this comment.
Not actually tested, but the code looks sane, follows Drupal core and is trivial enough. PLus tests passs, so happy enough to approve if that helps.
cjstevens78
approved these changes
Jun 9, 2021
Contributor
Author
|
Thanks Finn, thanks Chris. Merging... |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Form element description can appear both before and after the input item. At the
moment, only the after position is supported. Fixed now.
@see https://git.drupalcode.org/project/drupal/-/blob/9.2.x/core/modules/system/templates/form-element.html.twig