Add check for NodeInterface on object

[paulpopus]

Closes #132

[andybroomfield]

Think we should change the check to load the node if it is an int first, and then run this lest.
eg.

if (is_int($node) {
  $node = Node::load($node);
}

See inline comment for rationale.

[andybroomfield]

We still need to add the right hook when viewing a revision, else we don't get an accurate preview. So I suggest loading the node if it is an int.

<!-- FILE NAME SUGGESTIONS:
   x page--localgov-campaigns-page.html.twig
   * page--node--29.html.twig
   * page--node--%.html.twig
   * page--node.html.twig
   * page.html.twig
-->

And on a revision

<!-- FILE NAME SUGGESTIONS:
   * page--node--revisions--view.html.twig
   * page--node--revisions--96.html.twig
   * page--node--revisions--%.html.twig
   * page--node--revisions.html.twig
   * page--node--29.html.twig
   * page--node--%.html.twig
   * page--node.html.twig
   x page.html.twig
-->

(Assume same issue will be for subsites)

[finnlewis]

@paulpopus does this make sense to you? If not, give me a shout and we can discuss it.

[andybroomfield]

if (!$node instanceof NodeInterface) {
   $node = Node::load((int) $node);
}

[paulpopus]

@andybroomfield I've updated it, is this what you meant? Thanks a lot by the way

[andybroomfield]

Thanks @paulpopus with these changes revisions are now working and using the correct template suggestions.

[andybroomfield]

Can we hold on merging though until we know why the test fails.

[andybroomfield]

Thanks for your efforts @paulpopus
See inline comments, I think below should get the tests to pass.
So oddly, by fixing the revisions, we crash the tests when they are not loading a node.
This should also fix a scenario where someone does not use a node for the front page.

[andybroomfield]

I've added a new commit with the above fix to get the tests to pass. Of course I can't review it now, so if someone else wants to @finnlewis @Adnan-cds @cjstevens78 ?

[Adnan-cds]

I am getting WSOD for the entire site with this change. The error message is about memory exhaustion. That doesn't surprise me given that the check for if ($hook == 'page' && $node = \Drupal::routeMatch()->getParameter('node')) { has been dropped.

[Adnan-cds]

Thanks.