This repository was archived by the owner on Jan 7, 2025. It is now read-only.
Bug fix: Avoid duplicate field id #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, we are preparing the the field Id value, used in field templates, from its fieldname. This means *multiple* use of a particular field results in duplicate Ids in the markup. This is invalid. To resolve this, we need to ensure that field Ids are unique.
cjstevens78
approved these changes
Feb 2, 2021
Contributor
Author
|
This issue was picked up by Axe the accessibility checker. |
danchamp
approved these changes
Feb 9, 2021
Contributor
Author
|
Thanks Dan. That was quick! Merging... |
Collaborator
It's a good catch! Programmatically generated id attributes are easily overlooked and problems often not detected if only tested with one field of the type. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, we are preparing the field Id value, used in field templates,
from its fieldname. This means multiple use of a particular field results in
duplicate Ids in the markup. This is invalid. To resolve this, we need to
ensure that field Ids are unique.