Feature/146 skip main

[cjstevens78]

During a recent accessibility review on Croydon via the AXE auditor - it was flagged that the 'Skip to Main' link should be contained within a landmark.

I have wrapped the link in a <nav> landmark and denoted its function with an 'aria-label'.

I've checked this from a visual and functional pov and all is well.

[cjstevens78]

@danchamp another accessibility fix awaiting review - if you could cast your eye over it for me thanks chris

[paulpopus]

Correct me if I'm wrong but I think if you omit the aria-label on the <nav> element, the contents will be ready? I don't think that is a bad thing in this particular case.

Either way it looks good to me!

[cjstevens78]

Correct me if I'm wrong but I think if you omit the aria-label on the <nav> element, the contents will be ready? I don't think that is a bad thing in this particular case.

Either way it looks good to me!

@paulpopus yes i looked into this - normally you omit the label on a nav if it is the main navigation - but supplementary nav's need to be labelled - thanks!

[danchamp]

Sorry, late to review this. I think <nav> might be a case of 'too much accessibility'. The main beneficiaries of skip links are sighted keyboard users, and this change has no benefit to them. Users who rely on landmarks and use assistive tech with landmark support will already know where the main landmark is, and have the ability to navigate to it without the skip link.

The most disadvantaged by the <nav> will be screen-reader users who don't use landmarks, who will have the nav element label read to them (something like "Skip to Main Content navigation"), and then repeated in "Link: skip to main content".

I'd be more inclined to omit the wrapper element and move the <a> to be the first child of the <header> in header.html.twig. From a quick test this should work without any other changes required.

[cjstevens78]

@danchamp ok - good point thanks Dan - ill incorporate this in now and raise a new PR when ready