Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

Conversation

@Adnan-cds
Copy link
Contributor

For node pages, the current suggestion is adding a content type specific
template suggestion as the final one. This overrides Drupal's front-page
specific template suggestion making it impossible to have a frontpage
specific page template.

This change addresses this by restoring the frontpage specific template
suggestion to the final position.

For node pages, the current suggestion is adding a content type specific
template suggestion as the final one.  This overrides Drupal's front-page
specific template suggestion making it impossible to have a frontpage
specific page template.

This change addresses this by restoring the frontpage specific template
suggestion to the final position.
@Adnan-cds Adnan-cds marked this pull request as draft January 12, 2021 19:16
@Adnan-cds Adnan-cds requested a review from finnlewis January 14, 2021 11:44
@Adnan-cds Adnan-cds marked this pull request as ready for review January 14, 2021 11:45
@Adnan-cds
Copy link
Contributor Author

Example frontpage template suggestion from the current code:

  • page__localgov_subsites
  • page__front
  • ...

Proposed frontpage template suggestion from the changed code:

  • page__front
  • page__localgov_subsites
  • ...

This allows us to have a dedicated Twig template for the Subsite-based homepage.

Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible.

@Adnan-cds
Copy link
Contributor Author

Thanks Finn. Merging...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants