Changes for new alpha release #133
Conversation
…tyle button styling and build fix for ck style
…anges changes to buttons guides base styling breadcrumb and service pages
The set-env command is now deprecated. Replaced it with "Environment files". Deprecation notice: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ Example warning: https://github.com/localgovdrupal/localgov_theme/runs/1363228749?check_suite_focus=true#step:6:4
Replaces calls to deprecated set-env
change boostrap breakpoint classes for pages, campaigns and campaign …
…anges cta block and alert button styling
Adnan-cds
left a comment
Adnan-cds
left a comment
There was a problem hiding this comment.
Hi Chris, changes look mostly okay. I have commented on a few minor issues. Also, it would be great to have a summary of these changes as part of the Description of this pull request.
|
Thanks for updating the Description :) |
| /* Imports all styles needed to be included within the site's CK editor instances. */ | ||
|
|
||
| // Import council theme settings | ||
| @import 'theme'; // replace with '_variables-REPLACEWITHYOURCOUNCILNAME' |
There was a problem hiding this comment.
Sorry Chris, I missed this one last time. Is this not needed at all?
There was a problem hiding this comment.
@Adnan-cds no ive removed it because when we first put together the original croydon site, the one localgov was based on, we added this 'theme.scss' in knowing it would become a base shareable theme and thinking it would be a central place for users to put all of their modifiers when customising the base theme. However, thats not the route we have taken... modifiers are added to partials or duplicates of existing partials.
There was a problem hiding this comment.
Got it. Thanks for explaining.
Adnan-cds
left a comment
Adnan-cds
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks :)
| /* Imports all styles needed to be included within the site's CK editor instances. */ | ||
|
|
||
| // Import council theme settings | ||
| @import 'theme'; // replace with '_variables-REPLACEWITHYOURCOUNCILNAME' |
There was a problem hiding this comment.
Got it. Thanks for explaining.
Bringing in the latest changes as we require them for the croydon site to render correctly.