Rewrite services js to use es6 and remove jQuery #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You could remove the dependency on core/jquery from the libraries.yml for these submodules too. |
Contributor
|
@rupertj perhaps that's one for a follow up? We still have a little JQuery lurking in services status JS |
tonypaulbarker
approved these changes
Sep 9, 2025
Contributor
tonypaulbarker
left a comment
tonypaulbarker
left a comment
There was a problem hiding this comment.
I inspected the code and tested service status tabs (see https://demo.localgovdrupal.org/service-status ) and drag and drop on the Adult health and social care service landing page of the demo content /node/21/edit
Everything seems fine. No console errors.
See comments re: jQuery dependencies and remaining jQuery from Rupert and I.
Member
Added this issue #325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #321
What does this change?
We need to get this merged so our tests will start passing again.
How to test
Add a service page, set a parent for it, go to the parent page and check that you can still use the drag 'n' drop feature to drag the page to the 'child pages' field.
How can we measure success?
Our tests pass and continue to pass.
Thanks to Big Blue Door for sponsoring my time to work on this.