Skip to content

Conversation

@millnut
Copy link
Member

@millnut millnut commented Dec 31, 2024

What does this change?

Fixes #280

How to test

localgovdrupal/localgov_services:"dev-feature/2.x/drupal-11-support as 2.1.15"

Failures are eslint and stylelint, not related to D11 support.

How can we measure success?

Module works with both D10 and D11

@millnut millnut requested a review from ekes January 23, 2025 11:29
@millnut millnut changed the title [WIP] feat: drupal 11 support feat: drupal 11 support Jan 23, 2025
@millnut millnut marked this pull request as ready for review January 23, 2025 11:30
@ekes
Copy link
Member

ekes commented Feb 11, 2025

Usual 8.4 contrib issues.

But also test depends on workflows first.


1) Drupal\Tests\localgov_services\Functional\WorkflowsIntegrationTest::testPostLink
Unable to install modules: module 'localgov_workflows' is incompatible with this version of Drupal core.

/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:505
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:555
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
/var/www/html/web/modules/contrib/localgov_services/tests/src/Functional/WorkflowsIntegrationTest.php:57

OK looks like that's one got overlooked :-( localgovdrupal/localgov_workflows#114 almost there localgovdrupal/localgov_workflows#123

@finnlewis
Copy link
Member

Logged this issue to fix PHP 8.4 issues: #299

@finnlewis finnlewis merged commit cee8083 into 2.x Feb 13, 2025
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drupal 11 support

4 participants